Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement a team resource provider #5625

Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat: Implement a team resource provider #5625

merged 2 commits into from
Mar 6, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 27, 2024

Implement a team resource provider for nextcloud/server#42433

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well after the proposed change. CI found some formatting fixes that would need to be applied for making CI green.

lib/Teams/DeckTeamResourceProvider.php Outdated Show resolved Hide resolved
tests/integration/config/behat.yml Outdated Show resolved Hide resolved
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch meant to request changes, not approve 🙈

@juliusknorr juliusknorr marked this pull request as ready for review March 5, 2024 19:12
@juliusknorr juliusknorr requested a review from mejo- March 5, 2024 19:12
@juliusknorr juliusknorr mentioned this pull request Mar 5, 2024
28 tasks
@mejo- mejo- merged commit 044706f into main Mar 6, 2024
32 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/team-provider branch March 6, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants